Skip to content

Declare ext/standard constants in stubs - part 11 #9728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Declare ext/standard constants in stubs - part 11 #9728

merged 1 commit into from
Oct 12, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

cmb69
cmb69 approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(I suppose we should have deprecated CRYPT_STD_DES and friends already long ago.)

@kocsismate kocsismate merged commit c59e94f into php:master Oct 12, 2022
@kocsismate kocsismate deleted the const-standard11 branch October 12, 2022 10:07
@kocsismate
Copy link
Member Author

I suppose we should have deprecated CRYPT_STD_DES and friends already long ago.)

Added to my TODO list.

@cmb69
Copy link
Member

cmb69 commented Oct 12, 2022

If you like, you can add it to https://wiki.php.net/rfc/deprecations_php_8_3.

@kocsismate
Copy link
Member Author

If you like, you can add it to https://wiki.php.net/rfc/deprecations_php_8_3.

Nice! Exactly the very same RFC was my plan! Thanks for letting me know this one :) I'll add it sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69